Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weaver-go): upgraded Weaver Fabric Go SDK with membership functions #2901

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

VRamakrishna
Copy link
Contributor

@VRamakrishna VRamakrishna commented Nov 21, 2023

  • Added membership management functions for recording and lookup to Weaver Fabric Go SDK.
  • Fixed issues with the membership management functions in the Weaver Fabric Node SDK.
  • Updated the Weaver TS protobuf builder to generate output with proper imports. (This was required as the "grpc" dependency had been removed from the "package.json.")
  • Updated instructions in readme and docs. To test the added feature, please follow the instructions in weaver/sdks/fabric/go-sdk/readme.md#testing-membership-manager-functions

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added membership management functions for recording and lookup to Weaver Fabric Go SDK.
Fixed issues with the membership management functions in the Weaver Fabric Node SDK.
Updated the Weaver TS protobuf builder to generate output with proper imports.
(The above was required as the "grpc" dependency had been removed from the "package.json.")
Updated instructions in readme and docs.

Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: Sandeep Nishad <[email protected]>
@sandeepnRES sandeepnRES enabled auto-merge (rebase) December 7, 2023 09:12
@sandeepnRES sandeepnRES merged commit 43cce8e into hyperledger-cacti:main Dec 7, 2023
44 of 69 checks passed
sandeepnRES referenced this pull request Dec 21, 2023
…ting identity mgmt

Partially reverting changes made in https://github.com/hyperledger/cacti/pull/2901.
These changes made the IIN Agent chaincode operations fail.
Also fixed typos and formatting in the docs.

Signed-off-by: VRamakrishna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants